From 0af8a71d6a460c271f558d6e98ff025e768ef035 Mon Sep 17 00:00:00 2001 From: Uncle Stretch Date: Mon, 16 Nov 2026 20:09:11 +0300 Subject: [PATCH] clarify get_submission_probability parameters Signed-off-by: Uncle Stretch --- pallets/helpers/Cargo.toml | 2 +- pallets/helpers/src/lib.rs | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/pallets/helpers/Cargo.toml b/pallets/helpers/Cargo.toml index 11b378d..bc5166f 100644 --- a/pallets/helpers/Cargo.toml +++ b/pallets/helpers/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "ghost-helpers" -version = "0.0.17" +version = "0.0.18" description = "Cryptographic utility suite for custom runtimes: optimized Bitmaps, UTXO parsing, Merkle Tree proofs, and Hash Chain components." license.workspace = true authors.workspace = true diff --git a/pallets/helpers/src/lib.rs b/pallets/helpers/src/lib.rs index a5aed66..5d32366 100644 --- a/pallets/helpers/src/lib.rs +++ b/pallets/helpers/src/lib.rs @@ -53,25 +53,26 @@ where pub fn get_submission_probability( participants_count: usize, participated_count: usize, - block_until: B, - current_block: B + block_duration: B, + elapsed_blocks: B ) -> Perbill where B: UniqueSaturatedInto, { // P = ((participants_count - participated_count) / participants_count) - // * (current_block / block_until) + // * (elapsed_blocks / block_duration) let participants_count_u32: u32 = participants_count.unique_saturated_into(); let participated_count_u32: u32 = participated_count.unique_saturated_into(); - let block_until_u64: u64 = block_until.unique_saturated_into(); - let current_block_u64: u64 = current_block.unique_saturated_into(); + + let block_duration_u64: u64 = block_duration.unique_saturated_into(); + let elapsed_blocks_u64: u64 = elapsed_blocks.unique_saturated_into(); let participants_left = participants_count_u32.saturating_sub(participated_count_u32); let authorities_ratio = Perbill::from_rational(participants_left, participants_count_u32); - let blocks_ratio = Perbill::from_rational(current_block_u64, block_until_u64); + let time_window_ratio = Perbill::from_rational(elapsed_blocks_u64, block_duration_u64); - authorities_ratio.saturating_mul(blocks_ratio) + authorities_ratio.saturating_mul(time_window_ratio) } macro_rules! impl_ghost_hasher {