neptune/ghost-keychain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix uncaught promise if tab closes (#254)

Browse Source 
* Fix uncaught promise if tab closes

* Update packages/extension/src/background/handlers/index.ts
This commit is contained in:
Amaury Martiny 2020-02-26 17:37:36 +01:00 committed by GitHub
parent d78a1faa25
commit 3589b0a4d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/extension/src/background/handlers/index.ts
View File

@ -4,6 +4,8 @@
import { TransportRequestMessage, MessageTypes } from '../types';
import { assert } from '@polkadot/util';
import { PORT_EXTENSION } from '../../defaults';
import Extension from './Extension';
import State from './State';
@ -31,11 +33,18 @@ export default function handler<TMessageType extends MessageTypes> ({ id, messag
.then((response): void => {
console.log(`[out] ${source}`); // :: ${JSON.stringify(response)}`);
// between the start and the end of the promise, the user may have closed
// the tab, in which case port will be undefined
assert(port, `Port has been disconnected`);
port.postMessage({ id, response });
})
.catch((error): void => {
console.log(`[err] ${source}:: ${error.message}`);
port.postMessage({ id, error: error.message });
// only send message back to port if it's still connected
if (port) {
port.postMessage({ id, error: error.message });
}
});
}