diff --git a/CHANGELOG.md b/CHANGELOG.md index 13e9acd7..2afae16d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ Contributed: Changes: +- Make import from seed, QR & JSON options available on first-start - Latest upstream polkadot-js dependencies diff --git a/packages/extension-ui/src/Popup/Accounts/AddAccount.tsx b/packages/extension-ui/src/Popup/Accounts/AddAccount.tsx index 431eb781..289f4413 100644 --- a/packages/extension-ui/src/Popup/Accounts/AddAccount.tsx +++ b/packages/extension-ui/src/Popup/Accounts/AddAccount.tsx @@ -18,13 +18,14 @@ interface Props extends ThemeProps { function AddAccount ({ className }: Props): React.ReactElement { const onAction = useContext(ActionContext); const _onClick = useCallback( - (): void => onAction('/account/create'), + () => onAction('/account/create'), [onAction] ); return ( <>
diff --git a/packages/extension-ui/src/Popup/Authorize/Request.tsx b/packages/extension-ui/src/Popup/Authorize/Request.tsx index 3e0b2bcc..5e0c29a8 100644 --- a/packages/extension-ui/src/Popup/Authorize/Request.tsx +++ b/packages/extension-ui/src/Popup/Authorize/Request.tsx @@ -23,11 +23,11 @@ function Request ({ authId, className, isFirst, request: { origin }, url }: Prop const onAction = useContext(ActionContext); const _onApprove = (): Promise => approveAuthRequest(authId) - .then((): void => onAction()) + .then(() => onAction()) .catch((error: Error) => console.error(error)); const _onReject = (): Promise => rejectAuthRequest(authId) - .then((): void => onAction()) + .then(() => onAction()) .catch((error: Error) => console.error(error)); return ( diff --git a/packages/extension-ui/src/Popup/CreateAccount/index.tsx b/packages/extension-ui/src/Popup/CreateAccount/index.tsx index 2e335e70..cfa82148 100644 --- a/packages/extension-ui/src/Popup/CreateAccount/index.tsx +++ b/packages/extension-ui/src/Popup/CreateAccount/index.tsx @@ -2,7 +2,7 @@ // This software may be modified and distributed under the terms // of the Apache-2.0 license. See the LICENSE file for details. -import React, { useContext, useEffect, useState } from 'react'; +import React, { useCallback, useContext, useEffect, useState } from 'react'; import { ActionContext, Loading } from '../../components'; import { createAccountSuri, createSeed } from '../../messaging'; import { HeaderWithSteps } from '../../partials'; @@ -22,21 +22,24 @@ export default function CreateAccount (): React.ReactElement { }, []); // FIXME Duplicated between here and Import.tsx - const _onCreate = (name: string, password: string): void => { - // this should always be the case - if (name && password && account) { - setIsBusy(true); - createAccountSuri(name, password, account.seed) - .then((): void => onAction('/')) - .catch((error: Error): void => { - setIsBusy(false); - console.error(error); - }); - } - }; + const _onCreate = useCallback( + (name: string, password: string): void => { + // this should always be the case + if (name && password && account) { + setIsBusy(true); + createAccountSuri(name, password, account.seed) + .then(() => onAction('/')) + .catch((error: Error): void => { + setIsBusy(false); + console.error(error); + }); + } + }, + [account, onAction] + ); - const _onNextStep = (): void => setStep(step + 1); - const _onPreviousStep = (): void => setStep(step - 1); + const _onNextStep = useCallback(() => setStep((step) => step + 1), []); + const _onPreviousStep = useCallback(() => setStep((step) => step - 1), []); return ( <> @@ -44,21 +47,22 @@ export default function CreateAccount (): React.ReactElement { step={step} text='Create an account: ' /> - {account && (step === 1 - ? ( - - ) - : ( - - ) + {account && ( + step === 1 + ? ( + + ) + : ( + + ) )} ); diff --git a/packages/extension-ui/src/Popup/Derive/SelectParent.tsx b/packages/extension-ui/src/Popup/Derive/SelectParent.tsx index 8bfdd20c..7044193a 100644 --- a/packages/extension-ui/src/Popup/Derive/SelectParent.tsx +++ b/packages/extension-ui/src/Popup/Derive/SelectParent.tsx @@ -31,7 +31,7 @@ export function SelectParent ({ isLocked, onDerivationConfirmed, parentAddress } const passwordInputRef = useRef(null); const _goCreate = useCallback( - (): void => onAction('/account/create'), + () => onAction('/account/create'), [onAction] ); diff --git a/packages/extension-ui/src/Popup/Export.tsx b/packages/extension-ui/src/Popup/Export.tsx index 64022174..0bb2a16d 100644 --- a/packages/extension-ui/src/Popup/Export.tsx +++ b/packages/extension-ui/src/Popup/Export.tsx @@ -21,7 +21,7 @@ function Export ({ match: { params: { address } } }: Props): React.ReactElement< const [wrongPasswordHighlight, setWrongPasswordHighlight] = useState(false); const _goHome = useCallback( - (): void => onAction('/'), + () => onAction('/'), [onAction] ); diff --git a/packages/extension-ui/src/Popup/Forget.tsx b/packages/extension-ui/src/Popup/Forget.tsx index 6ccbf9a0..3e30f800 100644 --- a/packages/extension-ui/src/Popup/Forget.tsx +++ b/packages/extension-ui/src/Popup/Forget.tsx @@ -16,14 +16,14 @@ function Forget ({ match: { params: { address } } }: Props): React.ReactElement< const onAction = useContext(ActionContext); const _goHome = useCallback( - (): void => onAction('/'), + () => onAction('/'), [onAction] ); const _onClick = useCallback( (): Promise => forgetAccount(address) - .then((): void => onAction('/')) + .then(() => onAction('/')) .catch((error: Error) => console.error(error)), [address, onAction] ); diff --git a/packages/extension-ui/src/Popup/ImportQr.tsx b/packages/extension-ui/src/Popup/ImportQr.tsx index 0028f3d9..40dee916 100644 --- a/packages/extension-ui/src/Popup/ImportQr.tsx +++ b/packages/extension-ui/src/Popup/ImportQr.tsx @@ -18,7 +18,7 @@ export default function ImportQr (): React.ReactElement { const _onCreate = (): void => { if (account && name) { createAccountExternal(name, account.content, account.genesisHash) - .then((): void => onAction('/')) + .then(() => onAction('/')) .catch((error: Error) => console.error(error)); } }; diff --git a/packages/extension-ui/src/Popup/Signing/Request.tsx b/packages/extension-ui/src/Popup/Signing/Request.tsx index fbfebee3..0ae84a7e 100644 --- a/packages/extension-ui/src/Popup/Signing/Request.tsx +++ b/packages/extension-ui/src/Popup/Signing/Request.tsx @@ -63,18 +63,18 @@ export default function Request ({ account: { isExternal }, buttonText, isFirst, const _onCancel = (): Promise => cancelSignRequest(signId) - .then((): void => onAction()) + .then(() => onAction()) .catch((error: Error) => console.error(error)); const _onSign = (password: string): Promise => approveSignPassword(signId, password) - .then((): void => onAction()) + .then(() => onAction()) .catch((error: Error): void => { setError(error.message); console.error(error); }); const _onSignature = ({ signature }: { signature: string }): Promise => approveSignSignature(signId, signature) - .then((): void => onAction()) + .then(() => onAction()) .catch((error: Error): void => { setError(error.message); console.error(error); diff --git a/packages/extension-ui/src/partials/MenuAdd.tsx b/packages/extension-ui/src/partials/MenuAdd.tsx index 5918005f..f585ba83 100644 --- a/packages/extension-ui/src/partials/MenuAdd.tsx +++ b/packages/extension-ui/src/partials/MenuAdd.tsx @@ -37,7 +37,11 @@ function MenuAdd ({ className, reference }: Props): React.ReactElement { - Create new account (root or derived) + { + master + ? 'Create new account (root or derived)' + : 'Create new account' + }