neptune/ghost-portal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix plural/singular (#6319)

Browse Source 
* Fix plural/singular

When upgradableCount is 1, the banner should use singular: "You have 1 extension that needs"
Otherwise the banner should use plural: "You have 2 extensions that need"

* move conditional outside and duplicate strings

* Update packages/page-accounts/src/Accounts/BannerExtension.tsx

Co-authored-by: Jaco <jacogr@gmail.com>
This commit is contained in:
xnorly 2022-01-17 13:27:35 +01:00 committed by GitHub
parent c7a8a6080b
commit 0a313a277c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/page-accounts/src/Accounts/BannerExtension.tsx
View File

@ -40,7 +40,13 @@ function BannerExtension (): React.ReactElement | null {
return (
<Banner type='warning'>
<p>{t<string>('You have {{upgradableCount}} extensions that need to be updated with the latest chain properties in order to display the correct information for the chain you are connected to. This update includes chain metadata and chain properties.', { replace: { upgradableCount } })}</p>
<p>
{upgradableCount === 1
? t<string>('You have 1 extension that needs to be updated with the latest chain properties in order to display the correct information for the chain you are connected to.')
: t<string>('You have {{upgradableCount}} extensions that need to be updated with the latest chain properties in order to display the correct information for the chain you are connected to.', { replace: { upgradableCount } })
}
{t<string>(' This update includes chain metadata and chain properties.')}
</p>
<p><Trans key='extensionUpgrade'>Visit your <a href='#/settings/metadata'>settings page</a> to apply the updates to the injected extensions.</Trans></p>
</Banner>
);