From 1b3f049015c09abfd8e6bc181c7fd49d4b29ed52 Mon Sep 17 00:00:00 2001
From: Jaco <jacogr@gmail.com>
Date: Tue, 31 Jan 2023 13:23:28 +0200
Subject: [PATCH] Adjust next-gen waiting display (#8900)

* Adjust next-gen waiting display

* isElected status

* Re-use Active Status

* Relay Badge adjustment
---
 .../{Validator => Active}/Status.tsx          | 23 +++---
 .../{Validator => Active}/index.tsx           |  0
 .../{Validator => Active}/useExposure.ts      |  0
 .../{Validator => Active}/useHeartbeat.ts     |  0
 .../src/Validators/ListActive.tsx             |  8 +--
 .../src/Validators/ListWaiting.tsx            | 10 ++-
 .../src/Validators/Waiting/index.tsx          | 72 +++++++++++++++++++
 7 files changed, 91 insertions(+), 22 deletions(-)
 rename packages/page-staking2/src/Validators/{Validator => Active}/Status.tsx (80%)
 rename packages/page-staking2/src/Validators/{Validator => Active}/index.tsx (100%)
 rename packages/page-staking2/src/Validators/{Validator => Active}/useExposure.ts (100%)
 rename packages/page-staking2/src/Validators/{Validator => Active}/useHeartbeat.ts (100%)
 create mode 100644 packages/page-staking2/src/Validators/Waiting/index.tsx

diff --git a/packages/page-staking2/src/Validators/Validator/Status.tsx b/packages/page-staking2/src/Validators/Active/Status.tsx
similarity index 80%
rename from packages/page-staking2/src/Validators/Validator/Status.tsx
rename to packages/page-staking2/src/Validators/Active/Status.tsx
index ac06184acc..39966c1121 100644
--- a/packages/page-staking2/src/Validators/Validator/Status.tsx
+++ b/packages/page-staking2/src/Validators/Active/Status.tsx
@@ -10,7 +10,7 @@ import { Badge } from '@polkadot/react-components';
 import { useAccounts } from '@polkadot/react-hooks';
 
 interface Props {
-  heartbeat: UseHeartbeat;
+  heartbeat?: UseHeartbeat;
   isChilled?: boolean;
   isPara?: boolean;
   isRelay?: boolean;
@@ -18,7 +18,7 @@ interface Props {
   validator: Validator;
 }
 
-function Status ({ heartbeat: { authoredBlocks, isOnline }, isChilled, isPara, isRelay, nominators, validator: { isElected } }: Props): React.ReactElement<Props> {
+function Status ({ heartbeat: { authoredBlocks, isOnline } = {}, isChilled, isPara, isRelay, nominators, validator: { isElected } }: Props): React.ReactElement<Props> {
   const { allAccounts } = useAccounts();
 
   const isNominating = useMemo(
@@ -44,16 +44,15 @@ function Status ({ heartbeat: { authoredBlocks, isOnline }, isChilled, isPara, i
         )
         : emptyBadge
       }
-      {isRelay && (
-        isPara
-          ? (
-            <Badge
-              color='purple'
-              icon='vector-square'
-            />
-          )
-          : emptyBadge
-      )}
+      {isRelay && isPara
+        ? (
+          <Badge
+            color='purple'
+            icon='vector-square'
+          />
+        )
+        : emptyBadge
+      }
       {isChilled
         ? (
           <Badge
diff --git a/packages/page-staking2/src/Validators/Validator/index.tsx b/packages/page-staking2/src/Validators/Active/index.tsx
similarity index 100%
rename from packages/page-staking2/src/Validators/Validator/index.tsx
rename to packages/page-staking2/src/Validators/Active/index.tsx
diff --git a/packages/page-staking2/src/Validators/Validator/useExposure.ts b/packages/page-staking2/src/Validators/Active/useExposure.ts
similarity index 100%
rename from packages/page-staking2/src/Validators/Validator/useExposure.ts
rename to packages/page-staking2/src/Validators/Active/useExposure.ts
diff --git a/packages/page-staking2/src/Validators/Validator/useHeartbeat.ts b/packages/page-staking2/src/Validators/Active/useHeartbeat.ts
similarity index 100%
rename from packages/page-staking2/src/Validators/Validator/useHeartbeat.ts
rename to packages/page-staking2/src/Validators/Active/useHeartbeat.ts
diff --git a/packages/page-staking2/src/Validators/ListActive.tsx b/packages/page-staking2/src/Validators/ListActive.tsx
index 68f1f1381e..f10d6a5165 100644
--- a/packages/page-staking2/src/Validators/ListActive.tsx
+++ b/packages/page-staking2/src/Validators/ListActive.tsx
@@ -11,7 +11,7 @@ import { Table } from '@polkadot/react-components';
 import { useNextTick } from '@polkadot/react-hooks';
 
 import { useTranslation } from '../translate';
-import ValidatorRow from './Validator';
+import Active from './Active';
 
 interface Props {
   className?: string;
@@ -26,7 +26,7 @@ function ListActive ({ className = '', isRelay, points, sessionInfo, toggleFavor
   const { t } = useTranslation();
   const isNextTick = useNextTick();
 
-  const headerActive = useRef<[string?, string?, number?][]>([
+  const header = useRef<[string?, string?, number?][]>([
     // favorite, badges, details, expand
     [t<string>('validators'), 'start', 4]
   ]);
@@ -36,12 +36,12 @@ function ListActive ({ className = '', isRelay, points, sessionInfo, toggleFavor
       className={className}
       empty={isNextTick && validatorsActive && t<string>('No session validators found')}
       emptySpinner={t<string>('Retrieving session validators')}
-      header={headerActive.current}
+      header={header.current}
       isSplit
       legend={<Legend isRelay={isRelay} />}
     >
       {isNextTick && validatorsActive?.map((v) => (
-        <ValidatorRow
+        <Active
           isRelay={isRelay}
           key={v.key}
           points={points?.[v.stashId]}
diff --git a/packages/page-staking2/src/Validators/ListWaiting.tsx b/packages/page-staking2/src/Validators/ListWaiting.tsx
index 06faada80b..92bc74310d 100644
--- a/packages/page-staking2/src/Validators/ListWaiting.tsx
+++ b/packages/page-staking2/src/Validators/ListWaiting.tsx
@@ -11,7 +11,7 @@ import { useNextTick } from '@polkadot/react-hooks';
 
 import { useTranslation } from '../translate';
 import useValidatorsWaiting from '../useValidatorsWaiting';
-import ValidatorRow from './Validator';
+import Waiting from './Waiting';
 
 interface Props {
   className?: string;
@@ -27,7 +27,7 @@ function ListActive ({ className = '', favorites, isRelay, sessionInfo, toggleFa
   const isNextTick = useNextTick();
   const validatorsWaiting = useValidatorsWaiting(favorites, sessionInfo, validatorsActive);
 
-  const headerWaiting = useRef<[string?, string?, number?][]>([
+  const header = useRef<[string?, string?, number?][]>([
     // favorite, badges, details, expand
     [t<string>('waiting'), 'start', 4]
   ]);
@@ -37,15 +37,13 @@ function ListActive ({ className = '', favorites, isRelay, sessionInfo, toggleFa
       className={className}
       empty={isNextTick && validatorsWaiting && t<string>('No waiting validators found')}
       emptySpinner={t<string>('Retrieving waiting validators')}
-      header={headerWaiting.current}
+      header={header.current}
       isSplit
       legend={<Legend isRelay={isRelay} />}
     >
       {isNextTick && validatorsWaiting?.map((v) => (
-        <ValidatorRow
-          isRelay={isRelay}
+        <Waiting
           key={v.key}
-          sessionInfo={sessionInfo}
           toggleFavorite={toggleFavorite}
           validator={v}
         />
diff --git a/packages/page-staking2/src/Validators/Waiting/index.tsx b/packages/page-staking2/src/Validators/Waiting/index.tsx
new file mode 100644
index 0000000000..b1cc336cde
--- /dev/null
+++ b/packages/page-staking2/src/Validators/Waiting/index.tsx
@@ -0,0 +1,72 @@
+// Copyright 2017-2023 @polkadot/app-staking authors & contributors
+// SPDX-License-Identifier: Apache-2.0
+
+import type { Validator } from '../../types';
+
+import React from 'react';
+
+import { AddressSmall, Table } from '@polkadot/react-components';
+import { useToggle } from '@polkadot/react-hooks';
+
+import Status from '../Active/Status';
+
+interface Props {
+  className?: string;
+  toggleFavorite: (stashId: string) => void;
+  validator: Validator;
+}
+
+interface PropsExpanded {
+  className?: string;
+  validator: Validator;
+}
+
+function ValidatorExpanded ({ className = '' }: PropsExpanded): React.ReactElement<PropsExpanded> {
+  return (
+    <tr className={`${className} isExpanded isLast`}>
+      <td />
+      <td />
+      <td />
+      <td />
+    </tr>
+  );
+}
+
+function Validator ({ className = '', toggleFavorite, validator }: Props): React.ReactElement<Props> {
+  const [isExpanded, toggleExpanded] = useToggle();
+
+  return (
+    <>
+      <tr className={`${className} isExpanded isFirst packedBottom`}>
+        <Table.Column.Favorite
+          address={validator.stashId}
+          isFavorite={validator.isFavorite}
+          toggle={toggleFavorite}
+        />
+        <td
+          className='statusInfo'
+          rowSpan={2}
+        >
+          <Status validator={validator} />
+        </td>
+        <td className='address relative all'>
+          <AddressSmall value={validator.stashId} />
+        </td>
+        <Table.Column.Expand
+          isExpanded={isExpanded}
+          toggle={toggleExpanded}
+        />
+      </tr>
+      <tr className={`${className} isExpanded ${isExpanded ? '' : 'isLast'} packedTop`}>
+        <td colSpan={2} />
+        <td />
+        <td />
+      </tr>
+      {isExpanded && (
+        <ValidatorExpanded validator={validator} />
+      )}
+    </>
+  );
+}
+
+export default React.memo(Validator);