neptune/ghost-portal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adjust max payout batch size based on staking payout constant (#3609)

Browse Source
This commit is contained in:
Jaco Greeff 2020-09-04 12:49:35 +02:00 committed by GitHub
parent c1b6d300c8
commit 2ee471bd4a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -15,7 +15,8 @@ Contributed:
Changes:
- Add individual era-slash cancels on staking sleashes page
- Add individual era-slash cancels on staking slashes page
- Adjust max payout batch size (40 txs for 64 payees) based on staking payout constant
- Add "copy seed" button to align with the extension UX on new accounts
- Combine confirmation/backup of imports/new account into the modals (no double-modal)
- Fix ecdsa JSON import dialogs

15
packages/page-staking/src/Payouts/PayButton.tsx
View File

@ -14,7 +14,8 @@ import { useApi, useToggle } from '@polkadot/react-hooks';
import { useTranslation } from '../translate';
const MAX_BATCH_SIZE = 40;
const DEFAULT_BATCH = 40;
const DEFAULT_PAYOUTS = 64;
interface Props {
className?: string;
@ -28,10 +29,12 @@ interface SinglePayout {
validatorId: string;
}
function createExtrinsic (api: ApiPromise, payout: PayoutValidator | PayoutValidator[]): SubmittableExtrinsic<'promise'> | null {
function createExtrinsic (api: ApiPromise, payout: PayoutValidator | PayoutValidator[], maxPayouts: number): SubmittableExtrinsic<'promise'> | null {
const batchSize = DEFAULT_BATCH * (DEFAULT_PAYOUTS / maxPayouts);
if (Array.isArray(payout)) {
if (payout.length === 1) {
return createExtrinsic(api, payout[0]);
return createExtrinsic(api, payout[0], maxPayouts);
}
return api.tx.utility.batch(
@ -44,7 +47,7 @@ function createExtrinsic (api: ApiPromise, payout: PayoutValidator | PayoutValid
return payouts;
}, [])
.sort((a, b) => a.era.cmp(b.era))
.filter((_, index) => index < MAX_BATCH_SIZE)
.filter((_, index) => index < batchSize)
.map(({ era, validatorId }) => api.tx.staking.payoutStakers(validatorId, era))
);
}
@ -56,7 +59,7 @@ function createExtrinsic (api: ApiPromise, payout: PayoutValidator | PayoutValid
: api.tx.utility.batch(
eras
.sort((a, b) => a.era.cmp(b.era))
.filter((_, index) => index < MAX_BATCH_SIZE)
.filter((_, index) => index < batchSize)
.map(({ era }) => api.tx.staking.payoutStakers(validatorId, era))
);
}
@ -70,7 +73,7 @@ function PayButton ({ className, isAll, isDisabled, payout }: Props): React.Reac
useEffect((): void => {
api.tx.utility && payout && setExtrinsic(
() => createExtrinsic(api, payout)
() => createExtrinsic(api, payout, api.consts.staking.maxNominatorRewardedPerValidator?.toNumber() || DEFAULT_PAYOUTS)
);
}, [api, isDisabled, payout]);