From 7e20c2e75b02f181fcb703b485c59c11ec817d7f Mon Sep 17 00:00:00 2001
From: Jaco <jacogr@gmail.com>
Date: Tue, 8 Jun 2021 06:24:45 +0300
Subject: [PATCH] Check urls as part of tests (#5485)

---
 .github/workflows/lint-chain-urls.yml                 | 11 -----------
 package.json                                          |  1 -
 .../{ciChainUrls.spec.ts => endpoints/index.spec.ts}  |  4 ++--
 3 files changed, 2 insertions(+), 14 deletions(-)
 delete mode 100644 .github/workflows/lint-chain-urls.yml
 rename packages/apps-config/src/{ciChainUrls.spec.ts => endpoints/index.spec.ts} (87%)

diff --git a/.github/workflows/lint-chain-urls.yml b/.github/workflows/lint-chain-urls.yml
deleted file mode 100644
index 00586327e7..0000000000
--- a/.github/workflows/lint-chain-urls.yml
+++ /dev/null
@@ -1,11 +0,0 @@
-name: Chain
-on: [pull_request]
-
-jobs:
-  urls:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v2
-      run: |
-        yarn install --immutable | grep -v 'YN0013'
-        yarn ci:chainUrls
diff --git a/package.json b/package.json
index e384465527..ee7b7f2d2c 100644
--- a/package.json
+++ b/package.json
@@ -51,7 +51,6 @@
     "packElectron": "yarn build:release:electron && yarn clean:electronRelease && electron-builder build -mwl",
     "docs": "echo \"skipping docs\"",
     "ci:chainTypes": "polkadot-dev-run-test --silent packages/apps-config/src/ciChainTypes",
-    "ci:chainUrls": "polkadot-dev-run-test --silent packages/apps-config/src/ciChainUrls",
     "clean": "polkadot-dev-clean-build",
     "clean:electronBuild": "cd packages/apps-electron && polkadot-dev-clean-build",
     "clean:electronRelease": "cd packages/apps-electron && rm -rf release",
diff --git a/packages/apps-config/src/ciChainUrls.spec.ts b/packages/apps-config/src/endpoints/index.spec.ts
similarity index 87%
rename from packages/apps-config/src/ciChainUrls.spec.ts
rename to packages/apps-config/src/endpoints/index.spec.ts
index d00de93eaa..c46bd73a50 100644
--- a/packages/apps-config/src/ciChainUrls.spec.ts
+++ b/packages/apps-config/src/endpoints/index.spec.ts
@@ -3,7 +3,7 @@
 
 import { assert, isString } from '@polkadot/util';
 
-import { createWsEndpoints } from './endpoints';
+import { createWsEndpoints } from '.';
 
 interface Endpoint {
   name: string;
@@ -17,7 +17,7 @@ const endpoints = createWsEndpoints((k: string, v?: string) => v || k, true)
   .map((o): Partial<Endpoint> => ({ name: o.text as string, ws: o.value as string }))
   .filter((v): v is Endpoint => !!v.ws);
 
-describe('check configured chain urls', (): void => {
+describe('urls are all valid', (): void => {
   endpoints.forEach(({ name, ws }) =>
     it(`${name} @ ${ws}`, (): void => {
       assert(ws.startsWith('wss://'), `Expected ${ws} endpoint to start with wss:// `);