fix: improve amount error calculation by considering OpenGov-related locks (#11578)

This commit is contained in:
Arjun Porwal 2025-05-27 10:53:09 +05:30 committed by GitHub
parent 53fe2acc04
commit 7e673509df
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -7,16 +7,35 @@ import type { BN } from '@polkadot/util';
import { useMemo } from 'react';
import { createNamedHook, useApi, useCall } from '@polkadot/react-hooks';
import { BN_ZERO, hexToString } from '@polkadot/util';
// Consider only OpenGov-related locks
const openGovLockIds = ['referenda', 'convictionVoting', 'pyconvot'];
function useAmountErrorImpl (accountId?: string | null, amount?: BN | null, minAmount?: BN | null): boolean {
const { api } = useApi();
const balances = useCall<DeriveBalancesAll>(!!accountId && api.derive.balances.all, [accountId]);
return useMemo(
() => !amount || amount.isZero() || !minAmount || minAmount.gt(amount) || (
!!balances &&
amount.gt((balances.transferable || balances.availableBalance).sub(api.consts.balances.existentialDeposit))
),
() => {
if (!amount || amount.isZero() || !minAmount || minAmount.gt(amount) || !balances) {
return true;
}
// Filter out OpenGov-related locks (those that don't prevent staking)
const openGovLocks = balances.lockedBreakdown.filter((lock) => {
return openGovLockIds.includes(hexToString(lock.id.toHex()));
});
// Total locked amount that affects staking
const openGovLockedBalance = openGovLocks.reduce((acc, lock) => acc.add(lock.amount), BN_ZERO);
const usableBalance = (balances.transferable || balances.availableBalance)
.add(openGovLockedBalance)
.sub(api.consts.balances.existentialDeposit);
return amount.gt(usableBalance);
},
[api, amount, balances, minAmount]
);
}