From 904b07005a66689f161aede036c3608139307e29 Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Mon, 13 May 2019 15:59:04 +0200 Subject: [PATCH] Rework account & address modals (#1143) * Modal styling * Update account forgetting * Swap name prop to AddressRow/Summary to defaultName * typo * Backup modal * Don't allow edit on isTesting accounts * ChangePassword modal update * Label help on password labels * typo * Create & backup dialog * Addressbook forget * Update packages/app-accounts/src/modals/Forgetting.tsx Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/app-accounts/src/Creator.tsx Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/app-accounts/src/modals/Backup.tsx Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/app-accounts/src/modals/Backup.tsx Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/app-address-book/src/Forgetting.tsx Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/app-address-book/src/Forgetting.tsx Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/app-accounts/src/modals/ChangePass.tsx Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/app-accounts/src/modals/Backup.tsx Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/app-accounts/src/modals/Forgetting.tsx Co-Authored-By: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> --- packages/app-accounts/src/Creator.tsx | 79 ++++++++----------- packages/app-accounts/src/Editor.tsx | 8 +- .../app-accounts/src/{ => modals}/Backup.tsx | 34 +++++--- .../src/{ => modals}/ChangePass.tsx | 46 ++++++----- .../src/{ => modals}/Forgetting.tsx | 17 ++-- packages/app-address-book/src/Forgetting.tsx | 16 ++-- packages/app-staking/src/Account/index.tsx | 4 +- packages/app-staking/src/Accounts.tsx | 5 +- packages/app-staking/src/Overview/Address.tsx | 15 +--- packages/ui-app/src/AddressRow.tsx | 4 +- packages/ui-app/src/AddressSummary.tsx | 15 ++-- packages/ui-app/src/Labelled.tsx | 1 + packages/ui-app/src/styles/components.css | 14 +++- packages/ui-app/src/styles/semantic.css | 19 +++-- packages/ui-app/src/styles/theme/polkadot.css | 5 +- packages/ui-app/src/util/getAddrName.ts | 18 +++-- 16 files changed, 163 insertions(+), 137 deletions(-) rename packages/app-accounts/src/{ => modals}/Backup.tsx (71%) rename packages/app-accounts/src/{ => modals}/ChangePass.tsx (72%) rename packages/app-accounts/src/{ => modals}/Forgetting.tsx (65%) diff --git a/packages/app-accounts/src/Creator.tsx b/packages/app-accounts/src/Creator.tsx index de4ecac09c..fef55694ba 100644 --- a/packages/app-accounts/src/Creator.tsx +++ b/packages/app-accounts/src/Creator.tsx @@ -12,7 +12,7 @@ import FileSaver from 'file-saver'; import React from 'react'; import { DEV_PHRASE } from '@polkadot/keyring/defaults'; import { withApi, withMulti } from '@polkadot/ui-api'; -import { AddressSummary, Button, Dropdown, Input, Labelled, Modal, Password } from '@polkadot/ui-app'; +import { AddressRow, AddressSummary, Button, Dropdown, Input, Labelled, Modal, Password } from '@polkadot/ui-app'; import { InputAddress } from '@polkadot/ui-app/InputAddress'; import keyring from '@polkadot/ui-keyring'; import uiSettings from '@polkadot/ui-settings'; @@ -156,7 +156,7 @@ class Creator extends React.PureComponent { private renderInput () { const { t } = this.props; - const { deriveError, derivePath, isNameValid, isPassValid, isSeedValid, name, pairType, password, seed, seedOptions, seedType, showWarning } = this.state; + const { deriveError, derivePath, isNameValid, isPassValid, isSeedValid, name, pairType, password, seed, seedOptions, seedType } = this.state; const seedLabel = (() => { switch (seedType) { case 'bip': @@ -241,61 +241,50 @@ class Creator extends React.PureComponent { } - - {this.renderModalContent()} - {this.renderModalButtons()} - + {this.renderModal()} ); } - private renderModalButtons () { + private renderModal () { const { t } = this.props; + const { address, name, showWarning } = this.state; return ( - - -