From 964341ca576050ea33eea01b1d8d49513b659fb6 Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Tue, 4 Aug 2020 12:27:09 +0200 Subject: [PATCH] Threshold calc fix when members not (yet) retrieved (#3331) * Threshold calc fix when members not (yet) retrieved * numbers --- packages/page-council/src/Motions/Votes.tsx | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/page-council/src/Motions/Votes.tsx b/packages/page-council/src/Motions/Votes.tsx index 3d422f0f00..842df43a88 100644 --- a/packages/page-council/src/Motions/Votes.tsx +++ b/packages/page-council/src/Motions/Votes.tsx @@ -21,11 +21,14 @@ function Votes ({ isAye, members, threshold, votes }: Props): React.ReactElement const [counter, setCounter] = useState(''); useEffect((): void => { + const num = threshold.toNumber(); const max = isAye - ? threshold.toNumber() - : (members.length - threshold.toNumber()) + 1; + ? num + : members?.length + ? (members.length - num) + 1 + : 0; - setCounter(`${votes.length}/${max}`); + setCounter(`${votes.length}${max ? `/${max}` : ''}`); }, [isAye, members, threshold, votes]); return (