From a2d0eabf6672a6b5fbbd3582b41baad5c69f6463 Mon Sep 17 00:00:00 2001
From: Stefanie Doll <stefie.doll@googlemail.com>
Date: Wed, 15 May 2019 21:30:26 +0200
Subject: [PATCH] Toolbox App RPC method bugfix & cleanup (#1171)

* WIP

* Removed unused code

* Add missing init values to ui-params

* Removed unused import

* Poke Travis

* Removed console.log

* Happy linting

* re-added the unused prevProps
---
 packages/app-toolbox/src/Rpc/Selection.tsx | 10 +---------
 packages/ui-params/src/initValue.ts        |  7 ++++++-
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/packages/app-toolbox/src/Rpc/Selection.tsx b/packages/app-toolbox/src/Rpc/Selection.tsx
index b6ff128f36..eee7ac40b5 100644
--- a/packages/app-toolbox/src/Rpc/Selection.tsx
+++ b/packages/app-toolbox/src/Rpc/Selection.tsx
@@ -52,7 +52,6 @@ class Selection extends React.PureComponent<Props, State> {
           label={t('call the selected endpoint')}
           onChange={this.onChangeMethod}
         />
-        {this.renderAccount()}
         <Params
           key={`${rpc.section}.${rpc.method}:params` /* force re-render on change */}
           onChange={this.onChangeValues}
@@ -70,20 +69,13 @@ class Selection extends React.PureComponent<Props, State> {
     );
   }
 
-  // FIXME Currently the UI doesn't support signing for rpc-submitted calls
-  private renderAccount () {
-    return null;
-  }
-
   private nextState (newState: State): void {
     this.setState(
       (prevState: State): State => {
         const { rpc = prevState.rpc, accountId = prevState.accountId, values = prevState.values } = newState;
-        const hasNeededKey = true;
         const isValid = values.reduce((isValid, value) => {
           return isValid && value.isValid === true;
-        }, rpc.params.length === values.length && hasNeededKey);
-
+        }, rpc.params.length === values.length);
         return {
           isValid,
           rpc,
diff --git a/packages/ui-params/src/initValue.ts b/packages/ui-params/src/initValue.ts
index eb25fa2fdc..dac323e781 100644
--- a/packages/ui-params/src/initValue.ts
+++ b/packages/ui-params/src/initValue.ts
@@ -5,7 +5,7 @@
 import { RawParam$Value } from './types';
 
 import BN from 'bn.js';
-import { Bytes, Hash, TypeDef, TypeDefInfo, UInt, createType } from '@polkadot/types';
+import { Bytes, Hash, TypeDef, TypeDefInfo, U8a, UInt, createType } from '@polkadot/types';
 
 export default function getInitValue (def: TypeDef): RawParam$Value | Array<RawParam$Value> {
   if (def.info === TypeDefInfo.Vector) {
@@ -46,6 +46,7 @@ export default function getInitValue (def: TypeDef): RawParam$Value | Array<RawP
       return false;
 
     case 'String':
+    case 'Text':
       return '';
 
     case 'Moment':
@@ -77,8 +78,12 @@ export default function getInitValue (def: TypeDef): RawParam$Value | Array<RawP
     case 'Proposal':
     case 'Signature':
     case 'SessionKey':
+    case 'StorageKey':
       return void 0;
 
+    case 'Extrinsic':
+      return new U8a();
+
     default: {
       try {
         const instance = createType(type);