From a8ed300dc4dff84f23ab5e93016e2f941ed17362 Mon Sep 17 00:00:00 2001 From: Jaco Greeff Date: Thu, 31 Jan 2019 18:02:47 +0100 Subject: [PATCH] Small init changes (static state) (#663) * Small init changes (static state) * Hide vanity on empty accounts * Require accounts for apps, cleanup needsApi/needsCalls * Display InputAddress when disable (but no options) * Filter toolbox based on accounts * Accounts gated via app, don't display add * Cleanup linting * Validation display & clear on settings types * Split save for developer & general * Add Reset button to dev settings --- packages/app-123code/src/Transfer.tsx | 4 +- packages/app-accounts/src/Backup.tsx | 14 +- packages/app-accounts/src/ChangePass.tsx | 18 +- packages/app-accounts/src/Restore.tsx | 18 +- packages/app-accounts/src/index.tsx | 17 +- packages/app-addresses/src/index.tsx | 5 +- packages/app-democracy/src/Referendum.tsx | 22 +- packages/app-explorer/src/EventsRecent.tsx | 12 +- packages/app-extrinsics/src/index.tsx | 26 +- packages/app-settings/src/index.css | 2 +- packages/app-settings/src/index.tsx | 336 ++++++++++-------- .../app-staking/src/StakeList/Account.tsx | 14 +- .../app-staking/src/StakeList/Nominating.tsx | 16 +- packages/app-staking/src/index.tsx | 2 +- packages/app-storage/src/Selection/Raw.tsx | 14 +- packages/app-storage/src/Selection/index.tsx | 2 +- packages/app-toolbox/src/index.tsx | 25 +- packages/app-transfer/src/Transfer.tsx | 20 +- packages/app-transfer/src/index.tsx | 38 +- packages/apps/src/Content/index.tsx | 13 +- packages/apps/src/SideBar/Item.tsx | 23 +- packages/apps/src/SideBar/index.tsx | 36 +- packages/apps/src/routing/123code.ts | 9 +- packages/apps/src/routing/accounts.ts | 5 +- packages/apps/src/routing/addresses.ts | 5 +- packages/apps/src/routing/democracy.ts | 13 +- packages/apps/src/routing/explorer.ts | 5 +- packages/apps/src/routing/extrinsics.ts | 6 +- packages/apps/src/routing/nodeinfo.ts | 5 +- packages/apps/src/routing/settings.ts | 5 +- packages/apps/src/routing/staking.ts | 13 +- packages/apps/src/routing/storage.ts | 5 +- packages/apps/src/routing/toolbox.ts | 5 +- packages/apps/src/routing/transfer.ts | 13 +- packages/apps/src/types.ts | 12 +- packages/ui-api/src/with/call.tsx | 11 +- packages/ui-api/src/with/observable.tsx | 18 +- packages/ui-app/src/InputAddress/index.tsx | 11 +- packages/ui-app/src/InputFile.tsx | 5 +- packages/ui-app/src/Tabs.tsx | 7 +- packages/ui-app/src/types.ts | 1 + packages/ui-params/src/Param/Bytes.tsx | 10 +- packages/ui-params/src/Param/Tuple.tsx | 16 +- packages/ui-params/src/Param/Vector.tsx | 12 +- packages/ui-signer/src/Checks/Proposal.tsx | 16 +- packages/ui-signer/src/Checks/Transfer.tsx | 18 +- packages/ui-signer/src/Modal.tsx | 14 +- types.json | 3 +- 48 files changed, 446 insertions(+), 474 deletions(-) diff --git a/packages/app-123code/src/Transfer.tsx b/packages/app-123code/src/Transfer.tsx index 301b0668a2..f7c2fa4782 100644 --- a/packages/app-123code/src/Transfer.tsx +++ b/packages/app-123code/src/Transfer.tsx @@ -27,7 +27,7 @@ export default class Transfer extends React.PureComponent {

transfer

-
+
{ tx='balances.transfer' /> -
+
Make a transfer from any account you control to another account. Transfer fees and per-transaction fees apply and will be calculated upon submission.
diff --git a/packages/app-accounts/src/Backup.tsx b/packages/app-accounts/src/Backup.tsx index 7e3ac2fe24..0f0c04fca9 100644 --- a/packages/app-accounts/src/Backup.tsx +++ b/packages/app-accounts/src/Backup.tsx @@ -25,16 +25,10 @@ type State = { }; class Backup extends React.PureComponent { - state: State; - - constructor (props: Props) { - super(props); - - this.state = { - isPassValid: false, - password: '' - }; - } + state: State = { + isPassValid: false, + password: '' + }; render () { return ( diff --git a/packages/app-accounts/src/ChangePass.tsx b/packages/app-accounts/src/ChangePass.tsx index 0c8216ac9c..51cf7b2034 100644 --- a/packages/app-accounts/src/ChangePass.tsx +++ b/packages/app-accounts/src/ChangePass.tsx @@ -26,18 +26,12 @@ type State = { }; class ChangePass extends React.PureComponent { - state: State; - - constructor (props: Props) { - super(props); - - this.state = { - isNewValid: false, - isOldValid: false, - newPass: '', - oldPass: '' - }; - } + state: State = { + isNewValid: false, + isOldValid: false, + newPass: '', + oldPass: '' + }; render () { return ( diff --git a/packages/app-accounts/src/Restore.tsx b/packages/app-accounts/src/Restore.tsx index 696f71fdb2..6cf59becde 100644 --- a/packages/app-accounts/src/Restore.tsx +++ b/packages/app-accounts/src/Restore.tsx @@ -25,18 +25,12 @@ type State = { }; class Restore extends React.PureComponent { - state: State; - - constructor (props: Props) { - super(props); - - this.state = { - isFileValid: false, - isPassValid: false, - json: null, - password: '' - }; - } + state: State = { + isFileValid: false, + isPassValid: false, + json: null, + password: '' + }; render () { const { t } = this.props; diff --git a/packages/app-accounts/src/index.tsx b/packages/app-accounts/src/index.tsx index 5e0ee4e36a..c6585623c0 100644 --- a/packages/app-accounts/src/index.tsx +++ b/packages/app-accounts/src/index.tsx @@ -27,7 +27,7 @@ type Props = AppProps & I18nProps & { type State = { hidden: Array, - items: Array + tabs: Array }; class AccountsApp extends React.PureComponent { @@ -43,7 +43,7 @@ class AccountsApp extends React.PureComponent { this.state = { ...baseState, - items: [ + tabs: [ { name: 'edit', text: t('Edit account') @@ -72,8 +72,10 @@ class AccountsApp extends React.PureComponent { } static hideEditState () { + // Hide vanity as well - since the route order and matching changes, the + // /create/:seed route become problematic, so don't allow that option return { - hidden: ['edit'] + hidden: ['edit', 'vanity'] }; } @@ -93,7 +95,7 @@ class AccountsApp extends React.PureComponent { render () { const { basePath } = this.props; - const { hidden, items } = this.state; + const { hidden, tabs } = this.state; const renderCreator = this.renderComponent(Creator); return ( @@ -102,7 +104,7 @@ class AccountsApp extends React.PureComponent {